Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We��ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #649 multiple background images #650

Merged
merged 12 commits into from
Feb 17, 2021
Merged

Fix #649 multiple background images #650

merged 12 commits into from
Feb 17, 2021

Conversation

danfickle
Copy link
Owner

@danfickle danfickle commented Feb 12, 2021 •
edited
Loading

#649

WIP. Still to-do:

  • background-image
  • background-position
  • background-size
  • background-repeat
  • background-attachment
  • background shorthand property
  • Finalize test
  • Document on wiki
  • Page at-rule test
@danfickle
#649 Move background property builders to own file.
3cce513 
So they can easily be edited to all allow multiple values.
@danfickle
#649 Allow multiple values in background-image prop
54e5e1b 
+ Needs tests.
+ Needs other background propery support such as position and size.
@danfickle
#649 Test for multiple image support. Passing.
22ad732
@danfickle
#649 Fix build - background shorthand property
a27b3a1 
must be kept in sync.
@danfickle danfickle mentioned this pull request Feb 12, 2021
Closed
@danfickle
Copy link
Owner Author

This should now be complete. Documentation on the wiki:
CSS background properties
@danfickle danfickle marked this pull request as ready for review February 16, 2021 11:24
@danfickle danfickle merged commit 02719e8 into open-dev-v1 Feb 17, 2021
@danfickle danfickle deleted the 649_multiple_bg_images branch February 17, 2021 03:26
@danfickle danfickle mentioned this pull request Mar 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@danfickle