Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Allow enabling of anonymous provider via tenant configuration #802

Merged
merged 7 commits into from
Feb 8, 2021

Conversation

rsgowman
Copy link
Member

@rsgowman rsgowman commented Mar 5, 2020

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Can you add a reference to the API proposal in the description.

@hiranya911 hiranya911 removed their assignment Mar 6, 2020
@google-cla
Copy link

google-cla bot commented Dec 22, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@rsgowman
Copy link
Member Author

Can you add a reference to the API proposal in the description.

Done.

@google-cla
Copy link

google-cla bot commented Dec 23, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@dgibney
Copy link

dgibney commented Jan 30, 2021

Looks like this was almost over the line before the holidays hit. Hope this comment may bring it back on someone's radar. Thanks.

@rsgowman
Copy link
Member Author

rsgowman commented Feb 1, 2021

Thanks for the reminder. I'll get this in front of the appropriate people this week, and we'll see if we can finish it up. (It had stalled due to some internal launch processes, but those were cleared up just before the holidays.)

@rsgowman rsgowman force-pushed the rsgowman/enable_anon_auth branch from 5b98a08 to 2668d56 Compare February 4, 2021 19:22
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. Just a couple of questions.

src/auth/index.ts Outdated Show resolved Hide resolved
test/unit/auth/tenant-manager.spec.ts Show resolved Hide resolved
@rsgowman rsgowman assigned hiranya911 and unassigned rsgowman Feb 5, 2021
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911 hiranya911 assigned rsgowman and unassigned hiranya911 Feb 5, 2021
@rsgowman rsgowman merged commit a00ce05 into master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants