Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fcm): Declare send_each and send_each_for_multicast in __all__ #749

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

MarcoTomasRodriguez
Copy link
Contributor

The new send_each and send_each_for_multicast functions were not declared on __all__ (although they belong to the public API), showing some warnings on popular linters. This PR complements #706.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MarcoTomasRodriguez for your contribution! LGTM

@lahirumaramba lahirumaramba self-assigned this Jan 3, 2024
@lahirumaramba lahirumaramba merged commit b2173da into firebase:master Jan 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants