Change LogDebug to NSLog in app's swizzling code. #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-maurice
approved these changes
Dec 2, 2021
a-maurice
approved these changes
Dec 2, 2021
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @jonsimantov on commit 562f5c7
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
jonsimantov
added a commit
that referenced
this pull request
Dec 4, 2021
* Fix link in readme (#768) * update test devices (#757) * Timeout and Retry FTL failures and mark flakiness * Update C++ SDK version to 8.8.0. * Add Analytics header update to iOS SDK update. (#775) * Add Analytics header update to iOS SDK update. * Update Android dependencies - Wed Dec 01 2021 (#773) ### Android - com.google.firebase.firebase_database → 20.0.3 - com.google.firebase.firebase_perf → 20.0.4 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1527401903). Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> * Fix typo in log output. * Change Xcode version from 12.2 to 12.4 to ensure GitHub support. (#774) * Change Xcode version from 12.2 to 12.4 to ensure GitHub support. * Fix integration tests workflow to respect xcode_version in matrix. * Add extra newline to header comment. * Update iOS dependencies - Thu Dec 02 2021 (#779) * Update iOS dependencies - Thu Dec 02 2021 ### iOS - Firebase/Analytics → 8.10.0 - Firebase/Auth → 8.10.0 - Firebase/Core → 8.10.0 - Firebase/Crashlytics → 8.10.0 - Firebase/Database → 8.10.0 - Firebase/DynamicLinks → 8.10.0 - Firebase/Firestore → 8.10.0 - Firebase/Functions → 8.10.0 - Firebase/Installations → 8.10.0 - Firebase/Messaging → 8.10.0 - Firebase/RemoteConfig → 8.10.0 - Firebase/Storage → 8.10.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1528664697). * Add missing copyright lines. * Add Firestore release note. Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> Co-authored-by: Jon Simantov <jsimantov@google.com> * Properly convert milliseconds to seconds (#767) * Properly convert milliseconds to seconds Currently, a value expressed in milliseconds is directly assigned to a variable which is supposed to store seconds and it's later converted to mills again. Thus, convert properly upon assignment * Update readme.md * Change LogDebug to NSLog in app's swizzling code. (#783) * Change LogDebug to NSLog. * Change log message. * Add comment. * Add copyright line when importing Analytics iOS headers, if missing (#780) * Add copyright line to iOS headers * Make copyright conditional to whether the file already has one. * Also set Xcode version explicitly in Android workflow. (#786) * Timeout & retry "install integration test deps" step (#785) * Format code. Co-authored-by: Борис Рязанцев <88411548+borisssoft@users.noreply.github.com> Co-authored-by: Mou Sun <69009538+sunmou99@users.noreply.github.com> Co-authored-by: firebase-workflow-trigger[bot] <80733318+firebase-workflow-trigger[bot]@users.noreply.github.com> Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> Co-authored-by: pawelsnk <pawelsnk@o2.pl>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't call LogDebug during swizzling.
Testing
Can't repro the iOS 15 issue but this won't make things any worse...?
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.