Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force to recaptcha verification flow for phone auth in Simulators #10426

Merged
merged 9 commits into from
Nov 4, 2022
Merged

Force to recaptcha verification flow for phone auth in Simulators #10426

merged 9 commits into from
Nov 4, 2022

Conversation

renkelvin
Copy link
Contributor

@renkelvin renkelvin commented Oct 31, 2022 •
edited
Loading

In the latest Xcode and macOS versions, APNs is now supported in simulators. Before that, phone auth will always fallback to the recaptcha verification flow.
Since FCM doesn't support iOS 16 simulators yet, #9968, this change force the phone auth flow fallback to recaptcha in simulators.
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

Size Report 1

Affected Products

  • FirebaseAuth

    TypeBase (9876601)Merge (3a113aa)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ezV22c6oZA.html
@renkelvin renkelvin mentioned this pull request Nov 1, 2022
Closed
paulb777
paulb777 reviewed Nov 1, 2022
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the integration test Firebase project is in a bad state for the signin tests. Would you fix?
FirebaseAuth/Sources/AuthProvider/Phone/FIRPhoneAuthProvider.m Outdated Show resolved Hide resolved
FirebaseAuth/Sources/AuthProvider/Phone/FIRPhoneAuthProvider.m Outdated Show resolved Hide resolved
@renkelvin
Copy link
Contributor Author

It looks like the integration test Firebase project is in a bad state for the signin tests. Would you fix?

Yeah, it's fixed now.
@renkelvin renkelvin merged commit 3d6305a into master Nov 4, 2022
@renkelvin renkelvin deleted the fix-apns-16 branch November 4, 2022 00:25
@renkelvin renkelvin restored the fix-apns-16 branch November 4, 2022 00:26
@thedalelakes thedalelakes mentioned this pull request Nov 9, 2022
Closed
visumickey pushed a commit that referenced this pull request Nov 9, 2022
@visumickey
Force to recaptcha verification flow for phone auth in Simulators (#1…
1de1e38 
…0426)
@renkelvin renkelvin deleted the fix-apns-16 branch November 16, 2022 23:48
@firebase firebase locked and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: auth
5 participants
@renkelvin @google-oss-bot @paulb777 @morganchen12 @rosalyntan