Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force to recaptcha verification flow for phone auth in Simulators #10426

Merged
merged 9 commits into from
Nov 4, 2022
Merged

Force to recaptcha verification flow for phone auth in Simulators #10426

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bba19ad
Update FIRPhoneAuthProvider.m
Oct 31, 2022
c1e646b
Update FIRPhoneAuthProvider.m
Oct 31, 2022
b61c9f5
Update FIRPhoneAuthProvider.m
Nov 1, 2022
6bd893e
Update FIRPhoneAuthProvider.m
Nov 1, 2022
022313e
Update FIRPhoneAuthProvider.m
Nov 1, 2022
1b5b9e6
Update FIRPhoneAuthProvider.m
Nov 1, 2022
3583b29
Update FIRPhoneAuthProvider.m
Nov 1, 2022
5a70da9
Update FIRPhoneAuthProvider.m
Nov 1, 2022
85ed8c6
Update FIRPhoneAuthProvider.m
Nov 2, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update FIRPhoneAuthProvider.m
  • Loading branch information
Bkie Fsc committed Nov 1, 2022
commit 022313e143b84915ca8017f3220b64cfe8e1da81
8 changes: 6 additions & 2 deletions FirebaseAuth/Sources/AuthProvider/Phone/FIRPhoneAuthProvider.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,10 +596,14 @@ - (void)verifyClientAndSendVerificationCodeToPhoneNumber:(NSString *)phoneNumber
- (void)verifyClientWithUIDelegate:(nullable id<FIRAuthUIDelegate>)UIDelegate
completion:(FIRVerifyClientCallback)completion {
// Remove the simulator check below after FCM supports APNs in simulators
renkelvin marked this conversation as resolved.
Show resolved Hide resolved
#if TESTING
if (@available(iOS 17, *)) {
renkelvin marked this conversation as resolved.
Show resolved Hide resolved
if ([GULAppEnvironmentUtil isSimulator]) {
renkelvin marked this conversation as resolved.
Show resolved Hide resolved
[self reCAPTCHAFlowWithUIDelegate:UIDelegate completion:completion];
return;
NSDictionary *environment = [[NSProcessInfo processInfo] environment];
if ((environment[@"XCTestConfigurationFilePath"] == nil)) {
[self reCAPTCHAFlowWithUIDelegate:UIDelegate completion:completion];
return;
}
}
}
if (_auth.appCredentialManager.credential) {
Expand Down