-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data leaks after enabling and then disabling Analytics #5837
Comments
I found a few problems with this issue:
|
Thanks for the report - we're looking into this and will get back to you as soon as we find out what's going on. |
Can you please provide some debug log? |
Sure, here it is: First, app was launched without configuring Firebase, called these two methods
Logs:
Then, I logged out, logged into account with enabled analytics and called these methods
Logs
Then I logged out.
Logged into account with disabled Analytics
Then these methods were called:
Logs
Then I waited a little and switched to Springboard. Logs
Reopened the app, observed network request to and log:
|
Just FYI: our clients agreed to keep Crashlytics always on, so we will not be disabling Firebase completely at any point. The issue is no longer relevant for us, please, feel free to close if you don't plan to investigate further. |
Thanks for the update - it's important that we do keep this open and investigate to ensure we understand what's going on here and stop it since this shouldn't be happening. |
Hello, is there any investigation going on? I'm facing the same issue here. Unlike @uson1x , unfortunately, this is an unacceptable behavior due to our privacy policy. If it cannot be fix in a reasonable time, maybe a removal of firebase framework shall be necessary. Update: Same issue means: I do use
What kind of black magic have you done in binary framework, for there is nothing in source code... Please respond when there is something new. |
@ryanwilson As @shengyang998 mentions, this is also unacceptable for us due to our privacy policy. |
Hey folks, thanks for commenting. I'll get a more detailed answer soon, but a few things to note here: The APIs that show Re: the strings not being found in the source code, they're there just harder to find to avoid abuse from bots scanning GitHub: firebase-ios-sdk/GoogleDataTransport/GDTCCTLibrary/GDTCCTUploader.m Lines 115 to 164 in fa7b3f9
Question for both @shengyang998 and @volmus - can you please provide the exact API calls in the order you're making them, and the issue you're seeing? The original post had a variety of enabling, disabling, and deleting the |
Thank you for your information @ryanwilson . I will dig deeper with those. In my case: We use Cocoapods to integrate Firebase framework, and configure it with
The tested app is built with Since I didn't import it, so the network request maybe inside of some +load or +initialize method? Hope these information could help. |
Thanks for the quick reply @shengyang998. To confirm, you don't call Note: the above controls FirebaseAnalytics specifically, not all of Firebase. If you want to disable all automatic data collection for Firebase at startup, use the Edit: the other option is - if you have no intention of calling any Firebase APIs and don't want Analytics to ever be collected in a target, the safest bet is always to remove the code entirely. |
Thanks @ryanwilson I will try those keys. Yes, I didn't call To be clear, if I want to disable all automatic network request for Firebase and FirebaseAnalytics, I need to set Is that correct? |
Correct, the global key |
Thanks a lot, it seems to me that the issue is been fixed. At least I hope so. |
In our project we ran into the same issue. We want to use the Firebase Remoteconfig and still be able to turn tracking (user behavior statistics) dynamically on and off. After the newest updates on this Thread, we made following adjustments to our code: In the info.plist, we set :
as our default setting.
The problem still seems unsolved, because we ran into following bahaviour:
Operational:
As @ryanwilson mentioned before „[…] you can set the dataCollectionDefaultEnabled runtime property to true and it will persist across app launches for that device.“ Does that mean, it is not possible to turn it off again? Is this intentional behavior or are there any other solutions to this? Thanks in advance. |
Adding a “me too” to this bug. Specifically, I’m seeing an unexplained network call to app-measurement.com. [FIRApp configure] has not been called, and this is in the app’s Info.plist:
This is a violation of our privacy policy. Unfortunately if this isn’t fixed before our next update, we’ll be pulling Firebase from the app. |
Filed internal Analytics issue b/168251939 |
Firebase 6.33.0 includes changes to address this issue in Analytics. Please re-open this issue if it persists after updating. |
After updating our Firebase Library to 6.33.0, the problem still persists. Especially after enabling and re-disabling DataCollection and AnalyticsCollection. |
@eikSchli Apologies for the delay. Is this issue still happening in Firebase 7, and if so, which network calls are being triggered while data/analytics collection is disabled? |
@htcgh We are using Firebase 7.4.0, but still encounter this issue. We firstly setup Firebase with
But firebaselogging-pa.googleapis.com is still triggered, something wrong with our implementation? |
@haozhutw can you please share more information about this, specifically:
Note that the runtime flags do persist data and override any previous settings, so if you are also using a product like Crashlytics and have previously set the Crashlytics specific flag to Without knowing the full list of products you're using and a reproducible case (either within your app or ideally our quickstarts) we won't be able to make further progress on this. Thanks! |
Hey @uson1x. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically. If you have more information that will help us get to the bottom of this, just add a comment! |
Sorry for the late reply! To answer your questions one by one:
|
@swrobel the logs you're seeing are general purpose non-Analytics logs used by the Firebase team for metrics collection. If you don't have the Analytics SDK in your app, you don't have to worry about this issue. |
I don't have to worry about unexpected network requests every 30 seconds 🤔? Are you saying there's absolutely no way to disable this? |
@haozhutw Setting Could you please try adding Also, I would probably suggest to create a separate ticket for your issue as it looks quite different from the current one. |
Hey @uson1x. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically. If you have more information that will help us get to the bottom of this, just add a comment! |
Since there haven't been any recent updates here, I am going to close this issue. @uson1x if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this. |
[REQUIRED] Step 1: Describe your environment
[REQUIRED] Step 2: Describe the problem
In our app we want to dynamically turn on/off Firebase Analytics.
Some of our clients don't want any information to be sent to third-parties.
Some clients are ok with that. And we want to keep Firebase Analytics enabled for those.
We tried to implement such cut-off disabling functionality. But in our tests, if you first configure FIRApp+enable analytics and then disable+delete the FIRApp, some information is still sent to firebaselogging-pa.googleapis.com/app-measurement.com.
Is that a bug? Is there more reliable way to dynamically enable/disable Firebase/Analytics?
Thank you!
Steps to reproduce:
GET https://app-measurement.com/config/app/1:<some_id>:ios:<some_id>?platform=ios&app_instance_id=<some_id>&gmp_version=60600 HTTP/2.0
or
POST https://firebaselogging-pa.googleapis.com/v1/firelog/legacy/batchlog HTTP/2.0
with a long body.
We also have
FirebaseScreenReportingEnabled: NO
set in our app's .plist file.The text was updated successfully, but these errors were encountered: