-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InAppMessaging] Firebase in-app message stuck at top and can't be dismissed on iOS 13+ #6803
Comments
I found a few problems with this issue:
|
Nope the suggested solution using UIWindow.init(frame:) didn't work. At least not for me when building a custom version of the SDK (6.32.2) with the suggested fix. Maybe it's a iOS 13+ issue in some other way. |
When I try this myself with a custom window it does not happen on iOS 12, 13 nor 14. So the problem seems to be with firebase!?, but I don't know what's going wrong. I created a custom view controller and presented it in a window with
I do keep a strong reference to the window while it's presented but firebase seems to do that as well (in a static property in FIRIAMRenderingWindowHelper.m) My window is triggered from the same place as the firebase |
@Mattijah What's the size of the window frame? If it's zero, it's probably the same issue i have. I get the WoT of breaking constraints too. |
@antonjn Yeah, it's zero. I think it was working ok like a week ago though... At least if I remember this correctly. |
@antonjn By reverting changes I've managed to find out what causes this issue on my side. When the app starts, I call |
Thanks for the report. I'll dig into this later this week. |
@antonjn Could you provide a video with the gesture described here? I'm not able to reproduce.
|
RPReplay_Final1603987443.mov.zip In the simulator it's not misplaced but gone entirely, but you can still see that the window is zero and you'll get a bunch of breaking constraint warnings if the debugger is attached. |
I see. And is this message being triggered by a foreground, or a custom event that happens to fire at that time? |
custom event |
@christibbs I think the problem itself will most likely be somewhere else since I was having the exactly same issue without having to put the app in the background. Not sure how is this window/vc being presented and sized. |
Well some users seem to have this issue when the app comes to foreground, not all the time, but sometimes. I think it's related to background/foreground state in some way. But as I wrote before. I didn't get this problem when I did a quick test presenting my own custom VC in a window, so it seems to be somewhat related to firebase's implementation from my point of view. |
Yeah, definitely. Calling |
@christibbs Have you been able to reproduce this issue? |
I have exactly the same problem using react native. I also have the request authorization but I tried to delete it and the problem persist |
I wasn't able to reproduce this when I tried a week ago, but I'll get back on it since there are other reports. |
|
Ah, that might help. My tests have been on SceneDelegate apps. |
Finally was able to repro this consistently. Working on it now. |
I was able to fix @Mattijah's use case (triggering a system level alert at the same time as an in-app message) by using @antonjn I still haven't reproduced your use case though. You mentioned it comes from swiping into background and back while using a custom trigger. What iOS lifecycle event are you firing the custom trigger from? |
|
@antonjn Please re-open this if the issue persists after this fix. |
@christibbs Seems to have solved our problem! 🎉 |
Step 1: Describe your environment
Step 2: Describe the problem
Steps to reproduce:
This can probably be reproduced in any project under the same basic conditions.
Possible Solution:
There is no reason to use the new UIWindow.init(windowScene:) on iPhone devices and should be reverted back to the old implementation using UIWindow.init(frame:).
iOS 14 device (parts of the view removed from screenshot)
iOS 13 simulator view debugger
The text was updated successfully, but these errors were encountered: