Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote Config: inaccurate nullability annotations #8640

Closed
maksymmalyhin opened this issue Sep 9, 2021 · 2 comments
Closed

Remote Config: inaccurate nullability annotations #8640

maksymmalyhin opened this issue Sep 9, 2021 · 2 comments
Assignees
@ryanwilson
Labels
api: remoteconfig
Milestone
Firebase 9

Comments

@maksymmalyhin
Copy link
Contributor

In Firebase 8 the Remote Config API has the following inaccurate nullability annotations:

The inaccurate nullability annotations prevent safe handling of the nil cases in Swift.

This is a breaking change, so will require a major version bump.
@maksymmalyhin maksymmalyhin added this to the Firebase 9 milestone Sep 9, 2021
@ryanwilson
Copy link
Member

We should likely throw an exception here to alleviate this:

firebase-ios-sdk/FirebaseRemoteConfig/Sources/FIRRemoteConfig.m

Lines 104 to 105 in d4c4e8c

// TODO: Maybe throw an exception here? That'd be a breaking change though, but at this point
// RC can't work as expected.

@ncooke3 ncooke3 self-assigned this Mar 9, 2022
@ryanwilson ryanwilson assigned ryanwilson and unassigned ncooke3 Mar 31, 2022
ryanwilson added a commit that referenced this issue Mar 31, 2022
@ryanwilson
Fix Remote Config pre-configure access.
14efb5f 
Currently, when `RemoteConfig.remoteConfig()` is called before
`FirebaseApp.configure()` is called, Similar to Database, AppCheck, and
others we'll now throw an ObjC exception. We're not going to make it
nullable or throw a Swift compatible error since it'd affect the
callsite of every usage (either a `?` or `try`) and this is deemed a
programming error: `configure()` has to be called first.

Fixes #8640
@ryanwilson ryanwilson mentioned this issue Mar 31, 2022
Merged
ryanwilson added a commit that referenced this issue Mar 31, 2022
@ryanwilson
Fix Remote Config pre-configure access. (#9551)
500e182 
* Fix Remote Config pre-configure access.

Currently, when `RemoteConfig.remoteConfig()` is called before
`FirebaseApp.configure()` is called, Similar to Database, AppCheck, and
others we'll now throw an ObjC exception. We're not going to make it
nullable or throw a Swift compatible error since it'd affect the
callsite of every usage (either a `?` or `try`) and this is deemed a
programming error: `configure()` has to be called first.

Fixes #8640

* CHANGELOG
@ryanwilson
Copy link
Member

Fixed in #9551 which is merged to the Firebase 9 branch.
paulb777 pushed a commit that referenced this issue Apr 4, 2022
@ryanwilson @paulb777
Fix Remote Config pre-configure access. (#9551)
6a8b834 
* Fix Remote Config pre-configure access.

Currently, when `RemoteConfig.remoteConfig()` is called before
`FirebaseApp.configure()` is called, Similar to Database, AppCheck, and
others we'll now throw an ObjC exception. We're not going to make it
nullable or throw a Swift compatible error since it'd affect the
callsite of every usage (either a `?` or `try`) and this is deemed a
programming error: `configure()` has to be called first.

Fixes #8640

* CHANGELOG
@firebase firebase locked and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: remoteconfig
3 participants
@ryanwilson @maksymmalyhin @ncooke3