-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InApp message is shown every new session (timestamp of the impression record is always 0 seconds) #8907
Labels
api: inappmessaging
Firebase In App Messaging
Comments
I found a few problems with this issue:
|
paulb777
added
api: inappmessaging
Firebase In App Messaging
and removed
needs-triage
labels
Nov 2, 2021
alien190
added a commit
to alien190/firebase-ios-sdk
that referenced
this issue
Nov 3, 2021
…(timestamp of the impression record is always 0 seconds).
eldhosembabu
pushed a commit
that referenced
this issue
Dec 3, 2021
* Fix for issue #8907 InApp message is shown every new session (timestamp of the impression record is always 0 seconds).
Closing this issue since PR is merged. |
eldhosembabu
added a commit
that referenced
this issue
Dec 3, 2021
Updating changelog to reflect fix for #8907
eldhosembabu
added a commit
that referenced
this issue
Dec 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
CocoaPods
The problem description:
InAppMessages are shown every new session even though the scheduling is set to 'No more than one message every day'.
The problem is reasoned by incorrect timestamp of the impression record. It's always 0 seconds.
Here is the line from log:
[Firebase/InAppMessaging][I-IAM270002] Insert the first impression record for message 3223183152453255168 with timestamp in seconds as 0.000000
I think the bug is located in this line
firebase-ios-sdk/FirebaseInAppMessaging/Sources/Flows/FIRIAMDisplayExecutor.m
Line 320 in 6176fb1
This code:
[self.displayBookKeeper recordNewImpressionForMessage:messageID withStartTimestampInSeconds:self.lastDisplayTime];
probably should be fixed as:
[self.displayBookKeeper recordNewImpressionForMessage:messageID withStartTimestampInSeconds: [self.timeFetcher currentTimestampInSeconds ] ];
The text was updated successfully, but these errors were encountered: