Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: Add CalculateMd5Digest() function #10854

Merged
merged 20 commits into from
Feb 28, 2023
Merged

Firestore: Add CalculateMd5Digest() function #10854

merged 20 commits into from
Feb 28, 2023

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Feb 22, 2023 •
edited
Loading

This PR adds the C++ function CalculateMd5Digest() to the internal "util" directory. This is not part of the public API; it is just an implementation detail. The implementation of the md5 algorithm was copied from Chromium.
@dconeybe dconeybe self-assigned this Feb 22, 2023
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

dconeybe
dconeybe commented Feb 22, 2023
View reviewed changes
Firestore/core/src/util/md5_commoncrypto.cc Outdated Show resolved Hide resolved
Firestore/core/src/util/md5_openssl.cc Outdated Show resolved Hide resolved
@dconeybe dconeybe requested a review from milaGGL February 22, 2023 21:01
@dconeybe dconeybe changed the title Firestore: add logic to calculate md5 digests of strings Feb 22, 2023
@dconeybe dconeybe mentioned this pull request Feb 22, 2023
Merged
2 tasks
@google-oss-bot
Copy link

google-oss-bot commented Feb 22, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.26% (61db372) to 88.27% (f5aa0c4) by +0.01%.

    FilenameBase (61db372)Merge (f5aa0c4)Diff
    md5.cc?89.38%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tSKr4uTbL9.html
wu-hui
wu-hui approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!
@dconeybe dconeybe changed the base branch from master to mila/BloomFilter February 28, 2023 02:09
@dconeybe dconeybe requested a review from milaGGL February 28, 2023 02:13
milaGGL
milaGGL approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
@dconeybe dconeybe merged commit 698c946 into mila/BloomFilter Feb 28, 2023
@dconeybe dconeybe deleted the dconeybe/md5 branch February 28, 2023 13:27
@firebase firebase locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: firestore
4 participants
@dconeybe @google-oss-bot @wu-hui @milaGGL