Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex AI] Use struct instead of enum for HarmProbability #13854

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

andrewheard
Copy link
Contributor

Replaced the SafetyRating.HarmProbability enum with a struct to prevent breaking changes when new values are added (since switch statements must be exhaustively checked in Swift). This follows the same design pattern as #13728 (HarmCategory).

#no-changelog

@andrewheard andrewheard added this to the 11.4.0 - M155 milestone Oct 8, 2024
@andrewheard andrewheard marked this pull request as ready for review October 8, 2024 23:55
@andrewheard andrewheard requested a review from paulb777 October 8, 2024 23:55
@andrewheard andrewheard merged commit 1e63a55 into main Oct 9, 2024
38 checks passed
@andrewheard andrewheard deleted the ah/vertex-harmprobability branch October 9, 2024 00:47
MojtabaHs pushed a commit to MojtabaHs/firebase-ios-sdk that referenced this pull request Oct 17, 2024
@firebase firebase locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants