Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We��ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Firebase info to checkin requests (directly from FIRInstanceIDCheckinService) - b/124533860 #2509

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Add Firebase info to checkin requests (directly from FIRInstanceIDCheckinService) - b/124533860 #2509

merged 1 commit into from
Mar 11, 2019

Conversation

maksymmalyhin
Copy link
Contributor

  • Send Firebase info in the request header (directly from FIRInstanceIDCheckinService)

This is a replacement for #2500 to address the comment
@maksymmalyhin maksymmalyhin self-assigned this Mar 10, 2019
@maksymmalyhin maksymmalyhin mentioned this pull request Mar 10, 2019
Closed
ryanwilson
ryanwilson approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please wait for @chliangGoogle's approval.
@maksymmalyhin maksymmalyhin merged commit 0956f5d into master Mar 11, 2019
@maksymmalyhin maksymmalyhin deleted the mm/iid-platform-info-logging-simple-124533860 branch March 11, 2019 18:04
maksymmalyhin added a commit that referenced this pull request Mar 29, 2019
@maksymmalyhin
Revert "Send Firebase user agent from FIRInstanceIDCheckinService dir…
3516dcc 
…ectly (#2509) (b/124533860)"

This reverts commit 0956f5d.
@firebase firebase locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes
5 participants
@maksymmalyhin @paulb777 @ryanwilson @charlotteliang @googlebot