Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow failures in FirebaseMessaging #4245

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Allow failures in FirebaseMessaging #4245

merged 1 commit into from
Nov 6, 2019

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Nov 5, 2019

#4053 introduced a travis failure for Messaging. The issue is suspected to be test only.

This PR allows the failure to continue while being investigated (#4236) while allowing the overall build to go green.
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

wilhuff
wilhuff approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@paulb777
Copy link
Member Author

paulb777 commented Nov 6, 2019

cc: @chliangGoogle
@paulb777 paulb777 merged commit da88c98 into master Nov 6, 2019
@paulb777 paulb777 deleted the pb-optional-messaging branch November 6, 2019 00:16
@firebase firebase locked and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes
5 participants
@paulb777 @google-oss-bot @ryanwilson @wilhuff @googlebot