Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist schema version 7 #8850

Merged
merged 4 commits into from
Oct 22, 2021
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

Unlike all other migrations, we do not persist that we have migrated to version 7. This means we run the migration over and over again.

Fixes #8791

@google-oss-bot
Copy link

google-oss-bot commented Oct 21, 2021

Coverage Report

Affected SDKs

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    SDK overall coverage changed from 87.77% (121f56e) to 87.67% (ab4d3dc) by -0.10%.

    Filename Base (121f56e) Head (ab4d3dc) Diff
    exception.cc 73.68% 23.68% -50.00%
    exception_apple.mm 58.62% 89.66% +31.03%
    leveldb_key.cc 97.84% 98.30% +0.46%
    leveldb_migrations.cc 92.28% 92.31% +0.03%
    leveldb_opener.cc 76.81% 74.64% -2.17%
    ordered_code.cc 92.18% 90.14% -2.04%
    serializer.cc 87.97% 87.65% -0.33%
    watch_stream.cc 90.70% 95.35% +4.65%
    write_stream.cc 94.37% 90.14% -4.23%

Test Logs

Firestore/CHANGELOG.md Outdated Show resolved Hide resolved
Firestore/CHANGELOG.md Outdated Show resolved Hide resolved
@schmidt-sebastian schmidt-sebastian merged commit f8b7174 into master Oct 22, 2021
@schmidt-sebastian schmidt-sebastian deleted the schmidt-sebastian-patch-1 branch October 22, 2021 08:28
@firebase firebase locked and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.