Merge d8cac08 into e60188d

firebase · Mar 5, 2024 · 0088e11 · 0088e11
2 parents e60188d + d8cac08
commit 0088e11
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/.changeset/thirty-otters-hug.md b/.changeset/thirty-otters-hug.md
@@ -0,0 +1,5 @@
+---
+'@firebase/auth': patch
+---
+
+Fix possible XSS vulnerability through **FIREBASE_DEFAULTS** settings.
diff --git a/packages/auth/src/platform_browser/index.ts b/packages/auth/src/platform_browser/index.ts
@@ -89,9 +89,11 @@ export function getAuth(app: FirebaseApp = getApp()): Auth {
     ]
   });
 
-  const authTokenSyncUrl = getExperimentalSetting('authTokenSyncURL');
-  if (authTokenSyncUrl) {
-    const mintCookie = mintCookieFactory(authTokenSyncUrl);
+  const authTokenSyncPath = getExperimentalSetting('authTokenSyncURL');
+  // Don't allow urls (XSS possibility), only paths on the same domain
+  // (starting with '/')
+  if (authTokenSyncPath && authTokenSyncPath.startsWith('/')) {
+    const mintCookie = mintCookieFactory(authTokenSyncPath);
     beforeAuthStateChanged(auth, mintCookie, () =>
       mintCookie(auth.currentUser)
     );