Add signUp API method for auth-next #2892
Conversation
Binary Size ReportAffected SDKsNo changes between base commit (a627ebf) and head commit (4a5783c). Test Logs
|
we can make an implementation class later
avolkovi
force-pushed
the
avolkovi/auth-next-api-sign-up
branch
from
17ca4ca to
643e294
Compare
avolkovi
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
| { | ||
| method, | ||
| headers: { | ||
| 'Content-Type': 'application/json' |
There was a problem hiding this comment.
Not all APIs will have json content type. This is true for secure token endpoint.
There was a problem hiding this comment.
I don't think our prototype ever required that endpoint, what content type does it use? I suppose we can allow this to be passed in
| body: JSON.stringify(request) | ||
| } | ||
| : {}; | ||
| const response = await fetch( |
There was a problem hiding this comment.
You seem to hardcode the fetch call. I suppose you can polyfill this. But not sure this can be polyfilled for all environments (eg. Node.js, react-native). What is your plan regarding this.
There was a problem hiding this comment.
We are investigating react-native right now, suppose this can be passed in from the Auth object like we do with popupRedirectResolver
* User should be an interface for now we can make an implementation class later * Add API call to signUp * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers * Update tests to test a little more * [AUTOMATED]: Prettier Code Styling
* User should be an interface for now we can make an implementation class later * Add API call to signUp * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers * Update tests to test a little more * [AUTOMATED]: Prettier Code Styling
* User should be an interface for now we can make an implementation class later * Add API call to signUp * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers * Update tests to test a little more * [AUTOMATED]: Prettier Code Styling
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.