Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix App Check typings #5570

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Fix App Check typings #5570

merged 1 commit into from
Oct 4, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Oct 1, 2021

Fixes #5569

The two public facing providers (Custom and RecaptchaV3) implement an internal interface AppCheckProvider but they hide some of their public methods, causing them to be inconsistent with the internal interface.

If I tag AppCheckProvider @internal, the "implements AppCheckProvider" is still there on the two public types and there's an error because it can't find it.

I don't want to get rid of the "implements" because it is a helpful check in the internal code.

@hsubox76 hsubox76 requested a review from Feiyang1 as a code owner October 1, 2021 18:56
@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2021

⚠️ No Changeset found

Latest commit: ccc0c36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (e70de62) and head commit (a937017).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (e70de62) and head commit (a937017).

@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Oct 4, 2021
@hsubox76 hsubox76 merged commit 49dfeb3 into master Oct 4, 2021
@hsubox76 hsubox76 deleted the ch-appcheck-types branch October 4, 2021 18:54
@Feiyang1
Copy link
Member

Feiyang1 commented Oct 5, 2021

@hsubox76 please add a changeset

@hsubox76 hsubox76 mentioned this pull request Oct 5, 2021
@firebase firebase locked and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3 participants