Change _fail to use NETWORK_REQUEST_FAILED #7125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NhienLam
requested review from
lisajian,
prameshj,
renkelvin and
sam-gc
as code owners
🦋 Changeset detectedLatest commit: f3810d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (833,202 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
prameshj
reviewed
Mar 15, 2023
prameshj
reviewed
Mar 15, 2023
prameshj
approved these changes
Mar 15, 2023
renkelvin
pushed a commit
that referenced
this pull request
Mar 21, 2023
* Change _fail to use NETWORK_REQUEST_FAILED * Add changeset * Check if network error is propagated in error message
dwyfrequency
pushed a commit
that referenced
this pull request
Mar 23, 2023
* Change _fail to use NETWORK_REQUEST_FAILED * Add changeset * Check if network error is propagated in error message
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7118.
https://github.com/firebase/firebase-js-sdk/blob/master/packages/auth/src/api/index.ts#L184 throws INTERNAL_ERROR when there is a network error. However, https://github.com/firebase/firebase-js-sdk/blob/master/packages/auth/src/core/auth/auth_impl.ts#L309-L316 treats any error other than NETWORK_REQUEST_FAILED as token is invalid and signs user out which is not an expected behavior. Hence, we're changing it back to using NETWORK_REQUEST_FAILED.