Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of getGoogleAnalyticsClientId #7158

Merged
merged 24 commits into from
Apr 18, 2023
Merged

Add implementation of getGoogleAnalyticsClientId #7158

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
7071d2b
Add initial implementation of getGoogleAnalyticsClientId
dwyfrequency Mar 26, 2023
156137e
Update docs devsite
dwyfrequency Mar 26, 2023
510a89a
Add checkset
dwyfrequency Mar 26, 2023
41ef1bf
Update changeset description
dwyfrequency Mar 27, 2023
8f6ac07
Add link to client_id in docstring
dwyfrequency Mar 31, 2023
3e401cb
Update gtagWrapper to take variable number of args for potential fall…
dwyfrequency Apr 8, 2023
4c93e53
Add API test for getGoogleAnalyticsClientId
dwyfrequency Apr 10, 2023
c4b9792
Move API functionality to internal function
dwyfrequency Apr 11, 2023
54d83aa
Update docs for devsite
dwyfrequency Apr 11, 2023
2ecd32d
Removed unused function in test
dwyfrequency Apr 11, 2023
9f5cfb5
Update public api with async keyword
dwyfrequency Apr 11, 2023
c6d4109
Remove comment
dwyfrequency Apr 12, 2023
5516b49
Update doc string
dwyfrequency Apr 12, 2023
6eef67c
Update grammar of changeset
dwyfrequency Apr 12, 2023
eca9407
Remove console.log
dwyfrequency Apr 12, 2023
0e3b900
Update variable name from targetId to measurementId
dwyfrequency Apr 12, 2023
0ec1f27
Removed check for blank measurementId
dwyfrequency Apr 12, 2023
a585a16
Add ERROR_FACTORY for promise rejection
dwyfrequency Apr 13, 2023
953e499
Change fieldName from clientId
dwyfrequency Apr 13, 2023
7149472
Update AnalyticsError.NO_CLIENT_ID message
dwyfrequency Apr 13, 2023
93ed844
Merge branch 'master' into jd-getclientid-analytics-v2
dwyfrequency Apr 14, 2023
8332162
Testing adding comment
dwyfrequency Apr 18, 2023
888aba4
remove test comment
dwyfrequency Apr 18, 2023
9357f51
Remove comments
dwyfrequency Apr 18, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update doc string
  • Loading branch information
@dwyfrequency
dwyfrequency committed Apr 12, 2023
commit 5516b49d19f45b5453ad27a3b29883053a085d42
1 change: 0 additions & 1 deletion packages/analytics/src/functions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ export async function setUserProperties(
* @public
dwyfrequency marked this conversation as resolved.
Show resolved Hide resolved
*
* @param gtagFunction Wrapped gtag function that waits for fid to be set before sending an event
* @param properties Map of user properties to set
*/
export async function internalGetGoogleAnalyticsClientId(
gtagFunction: Gtag,
Expand Down