Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ContrastiveDataset and ContrastiveDistillationDataset #579

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Refactor ContrastiveDataset and ContrastiveDistillationDataset #579

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cb4e803
fixed to work with processing_class instead tokenizer after transform…
DemirTonchev Dec 20, 2024
6a69303
refactor attempt for ContrastiveDataset so that it does not blow RAM …
DemirTonchev Dec 23, 2024
09869e1
added Samplit strategy enum
DemirTonchev Dec 24, 2024
82474dc
improved logic and fixed iterator pattern
DemirTonchev Dec 24, 2024
d01dc36
fix for negative samples formula
DemirTonchev Dec 24, 2024
53eaace
added multilalbel support as in the original implementation
DemirTonchev Dec 24, 2024
3e3fa5f
ContrastiveDataset iterator refactor
DemirTonchev Dec 25, 2024
2d5e29b
trainer fixed to work with ContrastiveDataset iter method
DemirTonchev Dec 25, 2024
1c905b1
ContrastiveDistillationDataset iter refactor
DemirTonchev Dec 25, 2024
9cafa02
typing fix
DemirTonchev Dec 26, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
trainer fixed to work with ContrastiveDataset iter method
  • Loading branch information
@DemirTonchev
DemirTonchev committed Dec 25, 2024
commit 2d5e29b784b6573dba41ef9d814be7f32e051d54
2 changes: 1 addition & 1 deletion src/setfit/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ def get_dataset(
args.sampling_strategy,
max_pairs=max_pairs,
)
dataset = Dataset.from_list(list(data_sampler))
dataset = Dataset.from_generator(data_sampler.__iter__)
loss = args.loss(self.model.model_body)

return dataset, loss
Expand Down