Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default module root setting for configuration #4974

Merged
merged 12 commits into from
Nov 26, 2024

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Nov 15, 2024

Changes:

  • Adds a new settings object for configureBehavior
  • Adds a new field for defaultModuleRoot that determines the default directory where modules are installed to.

Tests:

  • Verify settings value is parsed correctly
  • Added E2E test to check that the module is installed to the directory specified from the settings.json file.
Microsoft Reviewers: Open in CodeFlow
@ryfu-msft ryfu-msft requested a review from a team as a code owner November 15, 2024 22:52
@ryfu-msft ryfu-msft changed the title Add setting to set the default module root for configuration Nov 15, 2024
JohnMcPMS
JohnMcPMS previously approved these changes Nov 18, 2024
florelis
florelis previously approved these changes Nov 22, 2024
src/AppInstallerCLIE2ETests/ErrorCommand.cs Show resolved Hide resolved
@ryfu-msft
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).
florelis
florelis previously approved these changes Nov 26, 2024
@ryfu-msft ryfu-msft merged commit f97417f into microsoft:master Nov 26, 2024
9 checks passed
@ryfu-msft ryfu-msft deleted the defaultModuleSetting branch November 26, 2024 20:45
coureurkennr1 pushed a commit to coureurkennr1/winget-cli that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants