Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not cache document responses when varying on accept-language header #6093

Merged
merged 1 commit into from
Jul 24, 2024
Merged

do not cache document responses when varying on accept-language header #6093

merged 1 commit into from
Jul 24, 2024

Conversation

escattone
Copy link
Contributor

@escattone escattone commented Jun 27, 2024 •
edited
Loading

@escattone escattone force-pushed the no-doc-caching-when-vary-on-accept-language-1500 branch 3 times, most recently from 36c6e53 to 55a4303 Compare June 28, 2024 17:08
@escattone escattone marked this pull request as ready for review June 28, 2024 17:10
@escattone escattone requested a review from akatsoulas June 28, 2024 17:10
@escattone escattone force-pushed the no-doc-caching-when-vary-on-accept-language-1500 branch 2 times, most recently from a5cc613 to e422238 Compare June 28, 2024 17:21
@escattone escattone force-pushed the no-doc-caching-when-vary-on-accept-language-1500 branch from e422238 to a044012 Compare July 10, 2024 19:09
smithellis
smithellis approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@smithellis smithellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @escattone - this looks nice.
@escattone escattone merged commit 421c376 into mozilla:main Jul 24, 2024
2 checks passed
@escattone escattone deleted the no-doc-caching-when-vary-on-accept-language-1500 branch July 24, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@escattone @smithellis