Taxonomy topics #6130
Taxonomy topics #6130
Conversation
There was a problem hiding this comment.
Really nicely done! I went through the new topics and sub-topics carefully, and I have just a few topic title nits. Also, it looks like
kitsune/kitsune/wiki/widgets.py
Line 14 in f9c7d42
needs to change to something like topics_and_subtopics = Topic.active.filter(product__isnull=False).all() in order to resolve the test failures.
|
|
||
| NEW_TOPICS_DATA = [ | ||
| { | ||
| "title": "Backup, recovery and sync", |
There was a problem hiding this comment.
Super nit. Josh would prefer a comma after "recovery".
| ], | ||
| }, | ||
| { | ||
| "title": "Search, tag and share", |
There was a problem hiding this comment.
Super nit. Josh prefers a comma after "tag".
| ], | ||
| }, | ||
| { | ||
| "title": "Add-ons, extensions and themes", |
There was a problem hiding this comment.
Super nit. Josh prefers a comma after "extensions".
| ], | ||
| }, | ||
| { | ||
| "title": "Passwords and sign-in", |
There was a problem hiding this comment.
Super nit. I think the guidelines suggest "sign in" (without the hyphen) instead of "sign-in".
akatsoulas
force-pushed
the
taxonomy-topics
branch
from
9ad72a6 to
6afaca0
Compare
|
Thanks @escattone for the quick and thorough review! |
No description provided.