Remove unreachable Firefox refresh button from download_firefox()
Jinja macro
#6136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mozilla/sumo#1716
This PR is the deeper solution to mozilla/sumo#1716. The more surface level fix is #6137. If we ever want to spend the effort to make the
Refresh Firefox
button work as intended in the future, then this PR should be closed and #6137 reviewed/merged instead.This PR arose from a deeper look from the symptom noted in mozilla/sumo#1716. Here's what I found:
Refresh Firefox
button created by thedownload_firefox()
Jinja macro is never shown, and can never be shown for multiple reasons. It has been this way for more than 6 years.Refresh Firefox
button is never shown except when displayed in a browser that is not Firefox.Refresh Firefox
button relies on the code inproducts.js
to check if it should be shown, but that code, in turn, relies on a call toUITour
, which only works when running in Firefox. So it's impossible for that specificRefresh Firefox
button to ever be shown.products.js
relies on the latest Firefox version to be added as a data attribute on theDownload Firefox
button, but that data attribute has not been provided for some time.products.js
and theRefresh Firefox
button portion of thedownload_firefox()
Jinja macro.