Migrate topics nav #6146
Merged
Migrate topics nav #6146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
escattone
requested changes
Jul 26, 2024
|
erm this is happening lately. I suspect that when I update an entry, there are changes outside of the visible block of the editor coming from Copilot. Thanks for catching those |
akatsoulas
force-pushed
the
migrate-topics-nav
branch
from
650abfb to
ad326b7
Compare
|
@escattone one more pass? |
escattone
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
r+wc
@akatsoulas Thanks, this looks good to me now, except for one more thing. It looks like the old slug save-share-and-sync-firefox-android is still missing.
akatsoulas
force-pushed
the
migrate-topics-nav
branch
from
ad326b7 to
8c83211
Compare
|
Thank you for this thorough review! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.