Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter by product in topic navigation. #6150

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Filter by product in topic navigation. #6150

merged 1 commit into from
Jul 30, 2024

Conversation

akatsoulas
Copy link
Collaborator

No description provided.

@akatsoulas akatsoulas mentioned this pull request Jul 29, 2024
Closed
@akatsoulas akatsoulas requested a review from escattone July 29, 2024 19:05
escattone
escattone requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting an error when I select one of the products in the product dropdown, and it's because the Topic.get_absolute_url() method is still designed for the old world of a topic always existing under a single product.

image

Otherwise, this looks good to me.
@akatsoulas
Copy link
Collaborator Author

Thanks for the prompt review. Since this code is looking good, I am merging this and I am going to tackle the error in mozilla/sumo#1917 which affects all articles.
@akatsoulas akatsoulas merged commit dbc2565 into mozilla:main Jul 30, 2024
2 checks passed
@akatsoulas akatsoulas deleted the filter-by-product branch July 30, 2024 07:48
2000400

This comment was marked as spam.

Sign in to view

@mozilla mozilla deleted a comment from 2000400 Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@akatsoulas @escattone @2000400