Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Topic get_absolute_url method. #6153

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

akatsoulas
Copy link
Collaborator

  • Simplify breadcrumb construction in wiki.
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

I think the following two calls to get_absolute_url() should include the product slug as well, so something like get_absolute_url(product.slug)?

kitsune/wiki/views.py Outdated Show resolved Hide resolved
* Simplify breadcrumb construction in wiki.
@akatsoulas akatsoulas force-pushed the topic-get-absolute-url branch from b5c2d96 to 5e12e4e Compare July 31, 2024 08:53
@akatsoulas akatsoulas merged commit 1cc64b7 into mozilla:main Jul 31, 2024
2 checks passed
@akatsoulas akatsoulas deleted the topic-get-absolute-url branch July 31, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants