Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control topic side nav from the admin. #6154

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Control topic side nav from the admin. #6154

merged 1 commit into from
Jul 30, 2024

Conversation

akatsoulas
Copy link
Collaborator

  • Abstract base class for Topic and Product
@akatsoulas akatsoulas requested a review from escattone July 30, 2024 13:37
@akatsoulas akatsoulas mentioned this pull request Jul 30, 2024
Closed
@akatsoulas
Control topic side nav from the admin.
cc0d8c8 
* Abstract base class for Topic and Product
escattone
escattone approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 🎉
kitsune/products/views.py
Comment on lines -134 to +133
topic_subquery = (
Topic.active.filter(slug__in=NAVIGATION_TOPICS)
.filter(slug=OuterRef("slug"))
.order_by("id")
.values("id")[:1]
)
topic_list = Topic.active.filter(id__in=Subquery(topic_subquery))
topic_list = Topic.active.filter(in_nav=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 🎉
@escattone escattone merged commit fd295f5 into mozilla:main Jul 30, 2024
2 checks passed
@akatsoulas akatsoulas deleted the topic-side-nav branch July 31, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@akatsoulas @escattone