Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back wagtail_urls to the urls.py #6230

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

smithellis
Copy link
Contributor

  • This is important for the localization work
  • Regardless, the addition is recommended by WT and is the common practice
  • I think being the final i18n item is the right place, as we want wt pages processed with locales

https://docs.wagtail.org/en/stable/advanced_topics/i18n.html#adding-a-language-prefix-to-urls

@smithellis smithellis marked this pull request as draft September 18, 2024 14:45
@smithellis
Copy link
Contributor Author

I need to make this production friendly.

@smithellis smithellis self-assigned this Sep 18, 2024
@akatsoulas
Copy link
Collaborator

Let me know when you want a review on this

@smithellis smithellis force-pushed the wagtail-add-wagtail-urls branch from e5b55ef to 3e24a4e Compare September 19, 2024 12:38
- This may be important for the localization work
- Regardless, the addition is recommended by WT and is the common
practice
- Add WAGTAIL_ENABLE setting
- Add check for enablement for urls
- Add wagtail_urls if WAGTAIL_ENABLE=True
@smithellis smithellis force-pushed the wagtail-add-wagtail-urls branch from 0f7bfce to bc7412c Compare September 19, 2024 20:12
@smithellis smithellis marked this pull request as ready for review September 20, 2024 13:52
@smithellis smithellis merged commit d33b05b into mozilla:main Sep 20, 2024
2 checks passed
@smithellis smithellis deleted the wagtail-add-wagtail-urls branch September 20, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants