Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright refactor EditProfileDataFlow, Top Navbar and user_pages classes #6232

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Playwright refactor EditProfileDataFlow, Top Navbar and user_pages classes #6232

merged 1 commit into from
Sep 20, 2024

Conversation

emilghittasv
Copy link
Collaborator

@emilghittasv emilghittasv commented Sep 20, 2024 •
edited
Loading

  • Mark the protected page functions as public.
  • Replace super() with self in page classes.
  • Use composition instead of multiple inheritance for the edit_profile_data_flow.py
@emilghittasv
- Mark the page functions as public.
108936a 
- Replace super() with self in page classes.
- Use composition instead of inheritance for the edit_profile_data_flow.py
@emilghittasv emilghittasv merged commit 1919c0c into mozilla:main Sep 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@emilghittasv @akatsoulas