Moderate topics for forum questions #6234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akatsoulas
force-pushed
the
moderation-tool
branch
3 times, most recently
from
18dd20f to
92894b1
Compare
escattone
requested changes
Sep 23, 2024
There was a problem hiding this comment.
In addition to the comments below, I noticed that the look of a flagged answer is different than the look of a flagged question:
- Should the lighter gray area be limited to just the
Content:section like it is for flagged answers? - I noticed that flagged answers have large empty gaps at the top and bottom.
Question
Answer
akatsoulas
force-pushed
the
moderation-tool
branch
from
b606ac1 to
f751fcf
Compare
|
@escattone PR updated. I added a forth commit to fix a bug in the flag_form. It was using the same ID of "report-abuse" for every entry in the page. As a result, JS was picking the first occurrence and was assigning the wrong flags |
escattone
reviewed
Sep 24, 2024
| <a class="sumo-button button-sm delete" href="{{ url('questions.delete_answer', object.content_object.question.id, object.content_object.id) }}">{{ _('Delete') }}</a> | ||
| {% endif %} | ||
| </div> | ||
| {% include 'flagit/includes/flagged_question.html' %} |
Comment on lines
3
to
4
| <h3 class="flagged-content__heading">{{ _('Title:') }}</h3> | ||
| <p class="flagged-content__title">{{ object.content_object.title }}</p> |
There was a problem hiding this comment.
Since we're using this for answers now as well, we shouldn't show the title for answers, right? I wonder if we could simply wrap this with a {% if object.content_object.title %}...{% endif %}?
escattone
approved these changes
Sep 24, 2024
akatsoulas
force-pushed
the
moderation-tool
branch
from
f751fcf to
9625ef6
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.