Validate topics in the clean method #6240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escattone
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Thanks for this @akatsoulas ! I should have done this as part of #6186.
In addition to the comments below -- which when addressed resolve at least one of the unit test failures -- I think one or two of the other unit test failures still need to be addressed as well.
akatsoulas
force-pushed
the
kb-topic-form
branch
2 times, most recently
from
ff0538f to
b1a9558
Compare
akatsoulas
force-pushed
the
kb-topic-form
branch
from
b1a9558 to
c194e4f
Compare
escattone
approved these changes
Sep 24, 2024
| raise forms.ValidationError(TOPIC_REQUIRED) | ||
|
|
||
| return c | ||
| associated_topics = Topic.active.filter(products__in=products).distinct() | ||
| invalid_topics = topics.difference(associated_topics) |
There was a problem hiding this comment.
❤️ Nice! I've overlooked this feature, so thanks for enlightening me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.