Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright refactor flows & classes belonging to AAQ #6242

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Playwright refactor flows & classes belonging to AAQ #6242

merged 1 commit into from
Sep 23, 2024

Conversation

emilghittasv
Copy link
Collaborator

  • Mark the aaq_form_page, questions_page, ways_to_contribute_pages page classes functions as public and replace super() with self.
  • Use composition instead of inheritance for the aaq_flow.py class.
  • Updating modified function calls in tests.
@emilghittasv
- Mark the aaq_form_page, questions_page, ways_to_contribute_pages pa…
0524e6e 
…ge classes functions as public and replace super() with self.

- Use composition instead of inheritance for the aaq_flow.py class.
- Updating modified function calls in tests.
escattone
escattone approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes!
@escattone escattone merged commit 8ceb202 into mozilla:main Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@emilghittasv @escattone