Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright refactor kb article related flows and classes #6251

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Playwright refactor kb article related flows and classes #6251

merged 1 commit into from
Sep 25, 2024

Conversation

emilghittasv
Copy link
Collaborator

  • Mark the functions from the kb related classes as public and replace super() with self.
  • Use composition instead of inheritance for the add_kb_article_flow.py and add_kb_media_flow.py class.
  • Updating modified function calls in tests.
@emilghittasv
- Mark the functions from the kb related classes as public and replac…
c43f5ab 
…e super() with self.

- Use composition instead of inheritance for the add_kb_article_flow.py and add_kb_media_flow.py class.
- Updating modified function calls in tests.
@emilghittasv emilghittasv merged commit f10a72b into mozilla:main Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@emilghittasv @akatsoulas @escattone