Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright refactor delete kb article and edit article metadata flows #6256

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Playwright refactor delete kb article and edit article metadata flows #6256

merged 1 commit into from
Sep 26, 2024

Conversation

emilghittasv
Copy link
Collaborator

  • Mark the functions from the kb article metadata class as public and replace super() with self.
  • Use composition instead of inheritance for the delete_kb_article_flow.py and edit_article_meta_flow.py class.
  • Updating modified function calls in tests.
  • Update the search summary used in tests to avoid failing with Deleted articles are still returned in search results sumo#1985
@emilghittasv
- Mark the functions from the kb article metadata class as public and…
9028995 
… replace super() with self.

- Use composition instead of inheritance for the delete_kb_article_flow.py and edit_article_meta_flow.py class.
- Updating modified function calls in tests.
@emilghittasv emilghittasv merged commit eee27a7 into mozilla:main Sep 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@emilghittasv @akatsoulas