Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright refactor kb localization flow #6268

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Playwright refactor kb localization flow #6268

merged 1 commit into from
Oct 1, 2024

Conversation

emilghittasv
Copy link
Collaborator

  • Using composition instead of inheritance inside the kb_localization_flow.py class.
  • Using self. instead of super() and making the functions public inside the kb_translate_article_page.py class.
  • Updating the modified function calls in tests.
@emilghittasv
- Using composition instead of inheritance inside the kb_localization…
0e57633 
…_flow.py class.

- Using self. instead of super() and making the functions public inside the kb_translate_article_page.py class.
- Updating the modified function calls in tests.
@emilghittasv emilghittasv merged commit 58ffa01 into mozilla:main Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@emilghittasv @akatsoulas