-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default moderation queue filtering to spam #6280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change, the /{locale}/flagged
page doesn't work when selecting All reasons
for the reason filter. In that case, the JS does a fetch with no reason added to the URL (since the value for the All reasons
case is the empty string) and since the view function defaults to a reason of "spam" in that case, you only see the spam moderation items instead of all moderation items.
I'm thinking we'll either have to make the "spam" reason have a value of the empty string as well as give the All reasons
selection a value of "all" or something like that, or else maybe we have to give the All reasons
selection a value of "all" and keep the value of "spam" as well?
c8dcad2
to
e464b6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is still off. When I load the page initially, it shows spam only, but when I then change the reason filter to "All reasons", nothing changes. The reason remains "spam".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+wc
I don't think the isInitialLoad
-related code is needed. When I remove it, this PR works great for me.
e464b6e
to
a6df7a2
Compare
No description provided.