Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default moderation queue filtering to spam #6280

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

akatsoulas
Copy link
Collaborator

No description provided.

Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, the /{locale}/flagged page doesn't work when selecting All reasons for the reason filter. In that case, the JS does a fetch with no reason added to the URL (since the value for the All reasons case is the empty string) and since the view function defaults to a reason of "spam" in that case, you only see the spam moderation items instead of all moderation items.

I'm thinking we'll either have to make the "spam" reason have a value of the empty string as well as give the All reasons selection a value of "all" or something like that, or else maybe we have to give the All reasons selection a value of "all" and keep the value of "spam" as well?

@akatsoulas akatsoulas force-pushed the moderation-default-spam branch from c8dcad2 to e464b6e Compare October 8, 2024 17:36
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is still off. When I load the page initially, it shows spam only, but when I then change the reason filter to "All reasons", nothing changes. The reason remains "spam".

Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

I don't think the isInitialLoad-related code is needed. When I remove it, this PR works great for me.

kitsune/sumo/static/sumo/js/flagit.js Outdated Show resolved Hide resolved
kitsune/sumo/static/sumo/js/flagit.js Outdated Show resolved Hide resolved
@akatsoulas akatsoulas force-pushed the moderation-default-spam branch from e464b6e to a6df7a2 Compare October 9, 2024 07:38
@akatsoulas akatsoulas merged commit ad827ac into mozilla:main Oct 9, 2024
1 of 2 checks passed
@akatsoulas akatsoulas deleted the moderation-default-spam branch October 9, 2024 08:08
@mozilla mozilla deleted a comment Oct 9, 2024
@mozilla mozilla deleted a comment Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants