Squash Wagtail migrations #6295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escattone
reviewed
Oct 16, 2024
There was a problem hiding this comment.
This ran without error for me locally, but I see that the DB migration is failing when run in CircleCI at the start of the unit tests. When I look at the squashed migration for the products app, I see that it's including some intermediate steps in the operations that, in the end, are removed. For example, for the Topic model, the product field is created, altered, and then finally removed -- likewise for the unique_together constraint and the ordering for that model. Perhaps we should manually adjust the operations to only include the final values for each model?
akatsoulas
force-pushed
the
squash-wagtail-migrations
branch
2 times, most recently
from
00f2686 to
4a02648
Compare
akatsoulas
force-pushed
the
squash-wagtail-migrations
branch
from
4a02648 to
684f534
Compare
smithellis
pushed a commit
to smithellis/kitsune
that referenced
this pull request
Dec 19, 2024
* Squash Wagtail migrations * Drop unique_constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.