Respect AAQ configuration in widgets #6297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akatsoulas
force-pushed
the
aaq-widget-404
branch
from
bab96ea to
71984ae
Compare
smithellis
requested changes
Oct 29, 2024
| {% elif aaq_context.has_public_forum %} | ||
| <p>{{ _('Still need help? Continue to ask your question on our forums.') }}</p> | ||
| {% endif %} | ||
| <p>{{ _('Still need help? Continue to ' + ('contact our support team' if has_support else 'ask your question on our forums') + '.') }}</p> |
There was a problem hiding this comment.
Will this allow the 'contact our support team' and 'ask your question on our forums' text to be translated easily? I'm not sure this concatenation method is better than using format. Open to thoughts.
There was a problem hiding this comment.
I think there's a valid point for the string extraction process since this is evaluated dynamically. That said, I am not sure how format can help in this case though. I am going to separate the strings in multiple lines.
| {% else %} | ||
| {% set link_name = "aaq-widget.aaq-step-3" %} | ||
| {% set next_step = url('questions.aaq_step3', product_slug=aaq_context.product_slug) %} | ||
| <p>{{ _('Still need help? Sign in to ' + ('contact our support team' if has_support else 'ask your question on our forums') + '.') }}</p> |
akatsoulas
force-pushed
the
aaq-widget-404
branch
from
71984ae to
39ebb01
Compare
|
Updated per comment. Merging this to proceed with testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.