[2018] Stop 500 error on page changes #6341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akatsoulas
approved these changes
Nov 14, 2024
kitsune/sumo/static/sumo/js/wiki.js
Outdated
| $diffView.slideDown(); | ||
| $this.parent().find('.close-diff').show(); | ||
| $this.parent().find('.loading').hide(); | ||
| console.log("Updating revision list with URL:", url); // Debugging output |
kitsune/sumo/static/sumo/js/wiki.js
Outdated
| }, {}); | ||
| localStorage.setItem('revision-list-filter', JSON.stringify(currentData)); // Save as JSON | ||
|
|
||
| console.log("Form data saved to localStorage:", currentData); // Debugging output |
kitsune/sumo/static/sumo/js/wiki.js
Outdated
| }); | ||
| // Retrieve and safely parse form data from localStorage | ||
| let formData = {}; | ||
| const savedFormData = localStorage.getItem('revision-list-filter'); |
There was a problem hiding this comment.
Probably a better option for the scenario at hand is the sessionStorage. Using sessionStorage will ensure that we won't have any stale data and we won't also exceed the capacity.
kitsune/sumo/static/sumo/js/wiki.js
Outdated
| } | ||
| if (e.which === 13) { | ||
| e.preventDefault(); | ||
| return false; |
There was a problem hiding this comment.
you can skip the return statement here
Also re-updates the revision list if there is data Also stops the 500 error use sessionStorage
smithellis
force-pushed
the
2018-navigating-back-to-revision
branch
from
75d8d08 to
6b04957
Compare
smithellis
added a commit
to smithellis/kitsune
that referenced
this pull request
Dec 19, 2024
Also re-updates the revision list if there is data Also stops the 500 error use sessionStorage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated wiki.js to retain form data between page changes
Also re-updates the revision list if there is data
Stops the 500 error