2019 - Update 'MultiUsernameField' to handle display names #6351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akatsoulas
reviewed
Nov 13, 2024
kitsune/sumo/form_fields.py
Outdated
| except User.DoesNotExist: | ||
| msg = _("{username} is not a valid username.") | ||
| try: |
There was a problem hiding this comment.
In order to avoid the nesting of the try/except clause you could use something like:
user = User.objects.filter(Q(username=username) | Q(profile__name=username).first()
akatsoulas
approved these changes
Nov 18, 2024
Use Q for improved query Fix issue where an invalid username forces full revision list
smithellis
force-pushed
the
2019-filter-username-or-displayname-update
branch
from
4d8b213 to
76db052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.