Expose segmentation tags in moderation #6360
Merged
+198
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akatsoulas
commented
Nov 19, 2024
|
|
||
| question = get_object_or_404(Question, pk=question_id) | ||
| if tag_ids: | ||
| sumo_tags = SumoTag.objects.filter(id__in=tag_ids) |
There was a problem hiding this comment.
This should be limited only to segmentation tags
There was a problem hiding this comment.
Added a custom manager to return non-archived tags that start with seg-
escattone
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Just some nits to consider, but it looks good! Thanks @akatsoulas!
| @@ -7,7 +7,12 @@ | |||
| <hgroup> | |||
| <h2 class="sumo-card-heading">{{ _('Flagged {t} (Reason: {r})')|f(t=object.content_type, r=object.get_reason_display()) }}</h2> | |||
| {% if object.notes %} | |||
| <p class="notes">{{ _('Other reason:') }} {{ object.notes }}</p> | |||
| {% if object.content_type.model == 'question' %} | |||
|
|
|||
There was a problem hiding this comment.
Nit. Remove this empty line?
| <p class="notes">{{ _('Other reason:') }} {{ object.notes }}</p> | ||
| {% if object.content_type.model == 'question' %} | ||
|
|
||
| <p class="notes">{{ _('Additional notes:') }}<a target="_blank" href="{{ object.content_object.get_absolute_url() }}">{{ object.notes }}</a></p> |
There was a problem hiding this comment.
Nit. Add space before link.
| const url = `/en-US/questions/${questionId}/add-tag-async`; | ||
| const response = await fetchData(url, { method: 'POST', body: { tags: selectedTags } }); | ||
| if (response) { | ||
| console.log(response.message); |
There was a problem hiding this comment.
Nit. Is this a leftover from debugging?
akatsoulas
force-pushed
the
seg-tags-moderation-tool
branch
from
0710e3e to
9033d1f
Compare
akatsoulas
force-pushed
the
seg-tags-moderation-tool
branch
from
9033d1f to
382b6f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.