Do not edit moderated questions #6364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akatsoulas
force-pushed
the
lock-moderated-question
branch
from
d211e08 to
513445b
Compare
escattone
approved these changes
Nov 20, 2024
kitsune/questions/models.py
Outdated
| @@ -392,6 +392,14 @@ def is_solved(self): | |||
| def is_offtopic(self): | |||
| return config.OFFTOPIC_TAG_NAME in [t.name for t in self.my_tags] | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
Nit (since it's only used once so far). Maybe use @cached_property (from functools) instead, since this performs a DB query?
akatsoulas
force-pushed
the
lock-moderated-question
branch
from
513445b to
2b5dc20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.