Add back updateRevisionList to ensure list populates with saved data #6367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akatsoulas
reviewed
Nov 21, 2024
| @@ -653,6 +653,8 @@ import collapsibleAccordionInit from "sumo/js/protocol-details-init"; | |||
| } | |||
| } | |||
|
|
|||
| updateRevisionList(); // Initial update | |||
There was a problem hiding this comment.
That was removed in a previous PR. Is this needed? If yes, where is it used. Staging seems to be working without this call.
There was a problem hiding this comment.
This call was used in my other PR that ensures the revision list pre-populates with sessionStorage data; so when you got back to the revision list, if there data, we want the revision list to populate vs. show the fields filled but have standard data. I removed this because I was thinking it may be part of the issue in with the revision list lookup having intermittent/strange failures, but realized that it isn't related and needs to go back.
akatsoulas
approved these changes
Nov 21, 2024
smithellis
deleted the
2019-ensure-list-fillswith-saved-data-on-reload
branch
smithellis
added a commit
to smithellis/kitsune
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.