Update topic tag on moderation #6372
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akatsoulas
force-pushed
the
update-topic-tag
branch
from
d2c4bfd to
3ebe8a0
Compare
escattone
reviewed
Nov 25, 2024
There was a problem hiding this comment.
When I update a question's topic via the moderation view, I still see the old topic tag when I view the question at /en-US/questions/{question_id}. It appears to be due to the redis-based caching of the question's my_tags property. Maybe clear that cache entry when the topic is updated, or else just cache the tags for the lifetime of the question instance by using cached_property instead?
akatsoulas
force-pushed
the
update-topic-tag
branch
from
3ebe8a0 to
334eb05
Compare
|
@escattone PR updated |
escattone
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.