Limit moderation access to specific group #6388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akatsoulas
force-pushed
the
moderation-group
branch
from
a9fe1bd to
28f78b9
Compare
escattone
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Nicely done, thanks @akatsoulas! I just have a small comment.
Comment on lines
+114
to
+121
| if only_active: | ||
| if not ( | ||
| request.user.is_active and request.user.groups.filter(name=group_name).exists() | ||
| ): | ||
| raise Http404 | ||
| else: | ||
| if not request.user.groups.filter(name=group_name).exists(): | ||
| raise Http404 |
There was a problem hiding this comment.
Nit. What do you think of the following instead?
if not (
(!only_active or request.user.is_active) and request.user.groups.filter(name=group_name).exists()
):
raise Http404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.