Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moderation timestamp to Question #6390

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

akatsoulas
Copy link
Collaborator

No description provided.

Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

@@ -147,6 +147,7 @@ class Question(AAQBase):
tags_cache_key = "question:tags:%s"
images_cache_key = "question:images:%s"
contributors_cache_key = "question:contributors:%s"
moderation_timestamp = models.DateTimeField(default=None, null=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. Maybe use moderated instead of moderation_timestamp to match the style of the other date-time fields like created and updated?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I spent some time on this. I had moderated but then I switched to more verbose naming schema which avoids confussion. When I am thinking of moderated I default to whether the question is moderated or not and I am not thinking timestamp.

@akatsoulas akatsoulas merged commit 1916951 into mozilla:main Dec 5, 2024
2 checks passed
@akatsoulas akatsoulas deleted the moderation-timestamp branch December 5, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants