Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fortran: create the Fortran module directory #12925

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fortran: create the Fortran module directory #12925

wants to merge 1 commit into from

Conversation

ggouaillardet
Copy link
Contributor

Refs. #12787
@ggouaillardet ggouaillardet marked this pull request as ready for review November 18, 2024 06:31
@hppritcha
Copy link
Member

I'd like to get #12226 in before we do any changes to the use-mpi-f08 folder
jsquyres
jsquyres approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get #12226 in before we do any changes to the use-mpi-f08 folder

I hear ya, but this is an issue for v5.0.x, and is being reported by our downstream packagers. This is a 1-line change in the use-mpi-f08 folder; even if it creates a conflict, it should be pretty easy to resolve. I'd vote to merge this now and cherry pick over to v5.0.x.
@hppritcha
Copy link
Member

please rebase to clear out the mpi4py error.
@ggouaillardet
fortran: create the Fortran module directory
64d27a8 
Refs. open-mpi#12787

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet ggouaillardet force-pushed the topic/fortran_moduledir_install branch from 3611519 to 64d27a8 Compare December 13, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Target: main
4 participants
@ggouaillardet @hppritcha @jsquyres @bosilca