Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(preact-iso): Use pushState/ replaceState for useLocation().route method #413

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

(preact-iso): Use pushState/ replaceState for useLocation().route method #413

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
56f83c8
Use history.replaceState for route function
piotr-cz Mar 9, 2021
43214d3
Add semicolons
piotr-cz Mar 9, 2021
0faacea
Add option to use object as a path
piotr-cz Mar 9, 2021
25fd059
Change object signature
piotr-cz Mar 9, 2021
7337f1c
Merge branch 'main' into feature/preact-iso-route-location
piotr-cz Mar 12, 2021
1f5654b
Merge branch 'main' into feature/preact-iso-route-location
piotr-cz Mar 15, 2021
d772def
Update code as per https://github.com/preactjs/wmr/pull/413#discussio…
piotr-cz Mar 15, 2021
81f18f7
Wrap reducer to allow different signature
piotr-cz Mar 22, 2021
3d0d9f4
Add changeset
piotr-cz Mar 24, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use history.replaceState for route function
  • Loading branch information
@piotr-cz
piotr-cz committed Mar 9, 2021
commit 56f83c868fd1b53de10b2db1b35337c4c65e35b8
10 changes: 9 additions & 1 deletion packages/preact-iso/router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,24 @@
import { h, createContext, cloneElement } from 'preact';
import { useContext, useMemo, useReducer, useEffect, useLayoutEffect, useRef } from 'preact/hooks';

const UPDATE = (state, url, push) => {
const UPDATE = (state, url) => {
/** @type {boolean|undefined} - History state update strategy */
let push = undefined

// user click (Mouse event)
if (url && url.type === 'click') {
const link = url.target.closest('a[href]');
if (!link || link.origin != location.origin) return state;

url.preventDefault();
push = true;
url = link.href.replace(location.origin, '');
// navigation (PopStateEvent)
} else if (typeof url !== 'string') {
url = location.pathname + location.search;
// manual invocation (useLocation().route)
} else {
push = false
}

if (push === true) history.pushState(null, '', url);
Expand Down